Add JSON ingestion gem shell#1199
Conversation
jwils
force-pushed
the
joshuaw/json-ingestion-gem-shell
branch
from
3643e2f to
63b3c9f
Compare
jwils
requested review from
BrianSigafoos-SQ,
ayousufi,
bsorbo,
jwondrusch and
myronmarston
as code owners
There was a problem hiding this comment.
/nit I'm not sure we need this file. There's nothing further in this file in #1205...will there ever be? Gems's don't have to have a "root" file like this. Can we drop it entirely?
(If something in our build require it to exist, feel free to leave it).
| # always pulls in this serializer by default), and this gem's code references `schema_definition` only | ||
| # via paths that are always already loaded by the time this gem is required. | ||
| spec.add_development_dependency "elasticgraph-schema_definition", ElasticGraph::VERSION | ||
| spec.add_dependency "elasticgraph-support", ElasticGraph::VERSION |
There was a problem hiding this comment.
IIRC we put add_dependency before add_development_dependency in all the other gemspecs because it's more "primary" -- mind doing it here?
| JSON Schema ingestion support for ElasticGraph. | ||
|
|
||
| This gem provides the schema-definition extension that generates JSON Schema artifacts for indexing | ||
| events and validates JSON-ingestion-specific schema options. |
There was a problem hiding this comment.
Long term, I think it'll make sense to move some JSON logic out of elasticgraph-indexer into here. Essentially, this gem should provide all logic related to ingesting JSON data. Stuff that is only used by the indexer when we ingest JSON events should not remain in elasticgraph-indexer as it won't be used by an alternate ingestion library (e.g. the proto one).
....but for now let's leave this as you've written it since the schema-definition stuff is what you are focused on with this PR stack.
2 participants
Why
Split the JSON ingestion extraction into reviewable steps so the gem packaging can be checked independently before code moves.
What
elasticgraph-json_ingestiongem shellRisk Assessment
Low — this only adds an empty extension gem package, lockfile wiring, and generated dependency docs.
References